Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voteToggle unused resource removed from string resources #699

Merged
merged 3 commits into from
Jun 19, 2023
Merged

voteToggle unused resource removed from string resources #699

merged 3 commits into from
Jun 19, 2023

Conversation

scottmmjackson
Copy link
Contributor

@scottmmjackson scottmmjackson commented Jun 16, 2023 •
edited
Loading

  • voteToggle unused string resource removed from resources

Fixes #698

dessalines
dessalines approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@beatgammit
Copy link
Contributor

Looks like woodpecker broke. Try getting it to trigger, e.g. by doing git commit --amend && git push --force. That should trigger a rebuild.

@dessalines dessalines enabled auto-merge (squash) June 19, 2023 12:45
@dessalines dessalines disabled auto-merge June 19, 2023 12:59
@dessalines dessalines merged commit 578a4e2 into LemmyNet:main Jun 19, 2023
@Eskuero
Copy link
Contributor

Eskuero commented Jun 19, 2023

Seems like you missed some of them.

app/src/main/res/values-ja/strings.xml:268: Error: "voteToggle" is translated here but not found in default locale 
app/src/main/res/values-fr/strings.xml:279: Error: "voteToggle" is translated here but not found in default locale 
app/src/main/res/values-nl/strings.xml:291: Error: "voteToggle" is translated here but not found in default locale

I will try to send a pull request tomorrow if nobody else does it.

@Eskuero Eskuero mentioned this pull request Jun 20, 2023
Merged
@scottmmjackson
Copy link
Contributor Author

@Eskuero those translations seem to have been added after the PR was opened. The entire values-ja tree was merged yesterday.

@scottmmjackson scottmmjackson deleted the sj-drop-voteToggle branch June 20, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@twizmwazin twizmwazin twizmwazin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop voteToggle unused string resource
5 participants
@scottmmjackson @beatgammit @Eskuero @dessalines @twizmwazin