Implement !community@instance and @user@instance links #683
Conversation
beatgammit
force-pushed
the
feat/implement-lemmy-links
branch
2 times, most recently
from
9640160 to
38425c2
Compare
|
This looks really great! Look forward to when its ready. |
beatgammit
force-pushed
the
feat/implement-lemmy-links
branch
from
38425c2 to
f66bafa
Compare
|
I'm happy to merge as-is, or I can take a couple days and figure out how to open community and user pages. If #583 gets merged, it'll at least prompt how to open it, which is better than what we have now. Preference? |
beatgammit
force-pushed
the
feat/implement-lemmy-links
branch
from
f66bafa to
d26bb05
Compare
They merely pop up a toast saying it's unimplemented, but the links are being created and handled.
beatgammit
force-pushed
the
feat/implement-lemmy-links
branch
from
d26bb05 to
892f0f3
Compare
| @@ -423,6 +423,14 @@ fun parseUrl(url: String): String? { | |||
| fun openLink(url: String, ctx: Context, useCustomTab: Boolean, usePrivateTab: Boolean) { | |||
| val url = parseUrl(url) ?: return | |||
|
|
|||
| if (url.startsWith("@")) { | |||
There was a problem hiding this comment.
Following #583, I don't think this section triggers. parseUrl will return a standard https link. This should probably be rewritten to check if a link appears to be a user or community link, and then handle it.
There was a problem hiding this comment.
I got excited and ended up doing that: https://github.com/twizmwazin/jerboa/tree/feat/implement-lemmy-links
There was a problem hiding this comment.
I looked through your changes, and you may want to consider setting navController outside of the MarkdownHelper.init() so it can easily be used in previews. What I did was make it nullable and made a setter for it, and then check it before passing it on to openLinks.
Just an idea, I'm certainly no expert here. 😄
There was a problem hiding this comment.
Yeah I think you're right, would welcome a PR for it.
|
I merged this as part of #692, thank you! |
They merely pop up a toast saying it's unimplemented, but the links are being created and handled.
Fixes #556.
Partial fix for #526 since short forms of lemmy links can be handled separately from other links.
Related to #454.