Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image upload cancel crash #671

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Fix image upload cancel crash #671

merged 3 commits into from
Jun 15, 2023

Conversation

noloman
Copy link
Contributor

@noloman noloman commented Jun 15, 2023 •
edited
Loading

Closes #421

Screen_recording_20230615_172521.webm

@twizmwazin twizmwazin merged commit 19c79b5 into LemmyNet:main Jun 15, 2023
@7heo
Copy link
Contributor

7heo commented Jun 15, 2023

@noloman Great, thanks, TIL about let. Quick question, when I did my initial patch (I essentially had the fix 🎉, just the wrong call...), flutter later reported, during build, that url != null would always evaluate to 'true'. Why does that work with let? Thanks!

Chris-Kropp pushed a commit to Chris-Kropp/jerboa that referenced this pull request Jun 16, 2023
@noloman @Chris-Kropp
Fix image upload cancel crash (LemmyNet#671)
a4afb79 
* Fix image upload cancel crash

* 💄 revert formatting changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines Awaiting requested review from dessalines dessalines is a code owner

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a new post with an image and cancelling the image selection crashes Jerboa
3 participants
@noloman @7heo @twizmwazin