Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation enhancements: Bottom Navigation, screen transitions, back button #670

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

nahwneeth
Copy link
Contributor

@nahwneeth nahwneeth commented Jun 15, 2023

Gist

  • Fixed bottom navigation bar.
  • Added some default screen transitions.
  • Hide back / close button if they do nothing.

Detailed

  • Bottom Navigation
    • Split the existing HomeActivity into 2 activities: FeedActivity & HomeActivity.
    • FeedActivity contains the posts list & filters, etc.
    • HomeActivity houses a second NavHost, a NavigationBar & Drawer.
  • Screen Transitions
    • Added Accompanist navigation animation as dependency.
    • All the main navigations have a slide in and out transition by default.
    • Removed the fade in and out transitions of the bottom navigation.
  • Other enhancements
    • The back button auto hides/shows based on the nav stack state. So opening screens using deep links or the nested screens in the HomeActivity don't have a back button.
    • Community & profiles open as separate screen instead of within the "search" tab.
    • Split up the navigation composables in the MainActivity into separate files.
    • Bottom nav bar opens login screen instead of showing a login toast.

Things to review carefully

  • Ensure all deep links and routes have the correct pattern and are working.

Closes

@nahwneeth nahwneeth force-pushed the navigation-enhancements branch from be0a92d to d4ecbc8 Compare June 15, 2023 15:30
@nahwneeth nahwneeth changed the title Bottom Navigation, screen transitions, back button Navigation enhancements: Bottom Navigation, screen transitions, back button Jun 15, 2023
@nahwneeth nahwneeth force-pushed the navigation-enhancements branch from c79e91b to 6da8447 Compare June 15, 2023 17:24
@nahwneeth nahwneeth force-pushed the navigation-enhancements branch from 1582b4a to faba61b Compare June 15, 2023 18:36
@nahwneeth nahwneeth force-pushed the navigation-enhancements branch from faba61b to 79cb127 Compare June 15, 2023 18:52
@twizmwazin twizmwazin merged commit 36bde45 into LemmyNet:main Jun 15, 2023
@dessalines
Copy link
Member

@twizmwazin @nahwneeth This was a massive change, right in the middle of my autogen_types rework, to prepare for v0.18.0 . I have to revert it, and this change will have to be rebased on that.

dessalines added a commit that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen transition animations
3 participants