Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show link dialog on long press #651

Closed
wants to merge 7 commits into from
Closed

Conversation

pipe01
Copy link
Contributor

@pipe01 pipe01 commented Jun 14, 2023

When long pressing a post thumbnail or image a dialog will show containing actions related to the post's link, similar to Boost. If the link is an image, an option to download it will be added.

image

}
}

Toast.makeText(context, "Saved image", Toast.LENGTH_SHORT).show()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Saved image" should be a stringResource

Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use string resources over literals, then it'll lgtm.

@@ -881,6 +884,23 @@ fun saveBitmap(
}
}

suspend fun saveImage(url: String, context: Context) {
Toast.makeText(context, "Saving image...", Toast.LENGTH_SHORT).show()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringResource.

@dessalines
Copy link
Member

Any updates?

@MV-GH
Copy link
Collaborator

MV-GH commented Aug 20, 2023

Obsolete by #1189

@MV-GH MV-GH closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants