Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors when updating changelog #617

Merged
merged 8 commits into from
Jun 19, 2023

Conversation

marcellogalhardo
Copy link
Contributor

  • Handle errors when updating changelog;
  • Move fetching logic from view to AppSettingsRepository;
  • Replace scope.launch by LaunchedEffect to avoid unnecessary calls during recompositions;
  • Use getValue delegate on states to reduce verbosity (no need for state.value = each time);

Fixes #378

@dessalines dessalines enabled auto-merge (squash) June 14, 2023 13:06
@twizmwazin
Copy link
Contributor

@marcellogalhardo Can you enable the option to allow maintainers to edit your pull request? We're ready to merge but we don't merge if the PR is out of date with main. If we can edit the branch I can get this merged tonight.

@marcellogalhardo
Copy link
Contributor Author

marcellogalhardo commented Jun 16, 2023

@marcellogalhardo Can you enable the option to allow maintainers to edit your pull request? We're ready to merge but we don't merge if the PR is out of date with main. If we can edit the branch I can get this merged tonight.

@twizmwazin you should have the rights now! I'm currently in holidays, so I have limited access to internet and I didn't see your notification before. Sorry for the inconvenience.

@dessalines
Copy link
Member

Mmmk I got this one updated, it should get merged soon.

@dessalines dessalines disabled auto-merge June 19, 2023 12:37
@dessalines dessalines merged commit 1acf3bf into LemmyNet:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instant crash on first run if no Internet access
3 participants