Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use image previewer when clicking on images in small cards and list view #614

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Use image previewer when clicking on images in small cards and list view #614

merged 1 commit into from
Jun 14, 2023

Conversation

twizmwazin
Copy link
Contributor

Fixes #513

@twizmwazin twizmwazin requested a review from dessalines as a code owner June 13, 2023 20:50
dessalines
dessalines approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests out okay, just needs conflicts fixed.

@twizmwazin twizmwazin force-pushed the add-image-preview-to-small-cards-and-list branch from 6278132 to 8491511 Compare June 14, 2023 08:15
@twizmwazin twizmwazin enabled auto-merge (squash) June 14, 2023 08:19
@twizmwazin twizmwazin merged commit 25d3f61 into LemmyNet:main Jun 14, 2023
@pipe01
Copy link
Contributor

pipe01 commented Jun 14, 2023

This makes it so that you can't click on non-image links now though.

@vijaykramesh vijaykramesh mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image viewer doesn't work in small card and list mode
3 participants
@twizmwazin @pipe01 @dessalines