Comment action bar fixes #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Show action bar by default for comments" setting now only affects comment trees in post listing views, not single comments in the user's inbox (replies/mentions), saved comments, or profile comments. This gives them convenient access to the action bar for single comments they're likely to want to interact with. Also allow user to toggle action bar visibility for inbox replies and mentions by long tapping on the comment body (not just the comment header), which makes this behaviour consistent with long tapping on comments in normal post listings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Show action bar by default for comments" setting now only affects comment trees in post listing views, not single comments in the user's inbox (replies/mentions), saved comments, or profile comments. This gives them convenient access to the action bar for single comments they're likely to want to interact with.
Also allow user to toggle action bar visibility for inbox replies and mentions by long tapping on the comment body (not just the comment header), which makes this behaviour consistent with long tapping on comments in normal post listings.