Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to share posts. #543

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

camporter
Copy link
Contributor

For #536 adds the ability to share posts. Either the linked post URL or the post directly will be shared.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Just address that one comment, as well as merge from main to fix conflicts.

@camporter camporter force-pushed the add_sharesheet_for_posts branch from 9215feb to 91dbb72 Compare June 14, 2023 03:17
@@ -47,6 +47,8 @@ import com.jerboa.db.AccountViewModel
import com.jerboa.getCommentParentId
import com.jerboa.getDepthFromComment
import com.jerboa.isModerator
import com.jerboa.openLink
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import com.jerboa.openLink

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@camporter camporter force-pushed the add_sharesheet_for_posts branch from 5e2ff87 to d43ccff Compare July 1, 2023 17:52
@camporter
Copy link
Contributor Author

Rebased again.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sry for my slowness on this. Thanks!

@dessalines dessalines merged commit 1b5edbf into LemmyNet:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants