Hide downvote button on comments and posts when disabled #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not have downvotes enabled LemmyNet#390
…ownvoting-disabled
|
Having a look at the linter problems |
|
The only way I could figure out to test it was to hardcode the new conditionals to false and see that the UI was as expected. So if the LocalSite.downvotes_enabled gives the right value it should work. Happy to do some more testing if you can teach me a better way to set that flag (I don't have my own lemmy test instance - yet). /Edit - just realised I can fiddle with the setting in SampleData to at least see the change in the preview. Seems to work fine. |
dessalines
reviewed
Jun 11, 2023
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/community/CommunityActivity.kt
Outdated
Show resolved
Hide resolved
…ownvoting-disabled
Also - fix another broken preview LemmyNet#390
|
Hm - weird. CI is failing on something I already pushed a fix for (unused import). I think github has gotten confused :) |
…ownvoting-disabled
twizmwazin
approved these changes
Jun 11, 2023
…ownvoting-disabled
lsim
deleted the
feature/lsim/390-hide-downvote-button-when-downvoting-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at this - it's my first 'proper' PR. I may have violated any number of code style rules and what not.
I'm threading a
siteViewinto the two composables where a check is needed in order to not render the downvote button.Githubs differ got a bit confused due to the indentation change. There shouldn't be any surprises in those parts, though.
Fixes #390