Fixing markdown line height issue. #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
reviewed
Jun 10, 2023
| @@ -893,3 +894,7 @@ fun Modifier.onAutofill(vararg autofillType: AutofillType, onFill: (String) -> U | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| fun spToPx(sp: TextUnit, context: Context): Int { | |||
There was a problem hiding this comment.
I think we should use a longer name than spToPx to make it more clear what the function does.
There was a problem hiding this comment.
Or you could add a KDoc comment
for example
/**
* Converts a scaleable pixel (sp) to an actual pixel (px)
*/
fun spToPx(sp: TextUnit, context: Context): Int {
twizmwazin
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown textview wasn't using the correct units, and it was also missing line height.