Simple filter to display matching instances in the dropdown. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
approved these changes
Jun 10, 2023
dessalines
reviewed
Jun 10, 2023
| @@ -147,7 +150,7 @@ fun LoginForm( | |||
| expanded = false | |||
| }, | |||
| ) { | |||
| instanceOptions.forEach { selectionOption -> | |||
| instanceOptions.filter { instance.isEmpty() || it.contains(instance) }.forEach { selectionOption -> | |||
There was a problem hiding this comment.
I noticed a lot of slowness and keyboard issues here, and it might be because the filtering is being done inside the ExposedDropdown.
https://alexzh.com/jetpack-compose-dropdownmenu/
Check the bottom of that page, it has an example of filtering. Very close to yours, but try it out.
onowrouzi
force-pushed
the
login_instance_filter
branch
from
b521137 to
278d312
Compare
|
Reverting this because it causes a lot of performance and weird issues with keyboards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
login_instace_filter.webm