Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add voting arrows and score to posts in "List" view mode #472

Merged
merged 6 commits into from
Jun 10, 2023
Merged

Add voting arrows and score to posts in "List" view mode #472

merged 6 commits into from
Jun 10, 2023

Conversation

a1studmuffin
Copy link
Contributor

Add voting arrows and score to posts in "List" view mode. Looks like this, basically what Boost and BaconReader does:

voting_arrows_list

@a1studmuffin
Copy link
Contributor Author

image

twizmwazin
twizmwazin suggested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we have a settings toggle for this?

@a1studmuffin a1studmuffin requested a review from twizmwazin June 9, 2023 08:34
twizmwazin
twizmwazin approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work as intended. May want to consider waiting for localization to merge.

twizmwazin
twizmwazin suggested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, one minor tweak

app/src/main/java/com/jerboa/db/AppDB.kt Show resolved Hide resolved
@a1studmuffin
Update AppDB.kt
3ea0019 
Don't bump db version - keep as part of db version 11
@a1studmuffin a1studmuffin requested a review from twizmwazin June 9, 2023 09:02
@a1studmuffin
Copy link
Contributor Author

All done, let me know if you need anything else. 👍

dessalines
dessalines approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx!

app/src/main/java/com/jerboa/db/AppDB.kt
@@ -361,6 +375,7 @@ abstract class AppDB : RoomDatabase() {
MIGRATION_8_9,
MIGRATION_9_10,
MIGRATION_10_11,
MIGRATION_11_12,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dessalines dessalines enabled auto-merge (squash) June 10, 2023 00:21
@dessalines dessalines merged commit bb15433 into LemmyNet:main Jun 10, 2023
@twizmwazin twizmwazin mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twizmwazin twizmwazin twizmwazin approved these changes

@dessalines dessalines dessalines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a1studmuffin @dessalines @twizmwazin