Comment action bar improvements #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove the markdown scaling applied to the editor which forced the text content to also be increased. Removed the compose-markdown package and created our own wrapper around the markwon libraries with a custom resolver for images. LemmyNet#373
twizmwazin
force-pushed
the
comment-action-bar-improvements
branch
from
91cc8d1 to
2ae96ae
Compare
I'll make an issue to add a user guide to the readme, and link it from somewhere within the app. |
dessalines
approved these changes
Jun 8, 2023
| @@ -518,6 +519,7 @@ fun UserTabs( | |||
| account = account, | |||
| moderators = listOf(), | |||
| isCollapsedByParent = false, | |||
| showActionBarByDefault = appSettingsViewModel.appSettings.value?.showCommentActionBarByDefault ?: true, | |||
|
Could we add an option to long press to collapse and tap to expand the action bar? |
|
No because tap collapses / uncollapses child comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently is built on top of #432. It adds an option to show action bars by default for comments. Currently this is built into database migration 11, but if there is a release before this is merged I will make it a different migration version. It also adds the ability to long-press on a comment to toggle the action bar state.
I can rebase this to work without #432, but the current markdown renderer does not expose an
onLongClickoption, so the long press would only work in the top and bottom bars.Addresses #319, #418