started localization for the app and added first german local #447
Conversation
There was a problem hiding this comment.
This is a great first step! I've internationalized a few other android apps, but was really daunted by this one. Laying the groundwork like you've done here is the difficult part :), thank you!
Run ./gradlew formatKotlin to pass lint, then once I get a minute I'll also grep through the code to make sure nothing's missing.
Once this passes
| @@ -302,8 +302,15 @@ val MIGRATION_9_10 = object : Migration(9, 10) { | |||
| } | |||
| } | |||
|
|
|||
| val MIGRATION_10_11 = object : Migration(10, 11) { | |||
There was a problem hiding this comment.
What's going on here? You should probably merge from main.
There was a problem hiding this comment.
I've had the issue that after an update the app crashed and told me i need a migration to work. Tried it that way. Maybe its not correct. Sorry i am new to this 😓
Will try to revert this.
There was a problem hiding this comment.
Haha no problem. Just merge from main and you should be good.
|
I ran formatKotlin. Please be so kind and check if updating from the former version is running. :) For now a few strings in the Toasts are missing because of the missing context in those cases but i think its a start. |
|
Hrm... formatting still had issues. https://woodpecker.join-lemmy.org/dessalines/jerboa/pipeline/128/3 |
|
Wasn't the formatting, it was a merge error, i fixed it right now. |
Could you add context to those? It'd be good to get all the strings now, because once people start adding languages, it'll be tougher later on. If not I can probably help out in a day or two. |
|
And ran into another merge conflict, you guys are working to fast 😂 |
Honestly i can look into it tomorrow. Its 11:30pm here and i had a few Whiskeys already. I am well beyond the Ballmer Peak 😅 |
|
Give me a minute, i've found the context solution. Maybe the Ballmer Peak is not a lie... |
|
I have added the three toasts i have found and it should work now. Please check it if you can. |
|
Mmmk I'll check now. |
|
I found a good number of toasts and Do a That should give you a full list. |
|
Searched for Text( and text = to be sure to find everything. I think i have it covered now. |
|
I did again a search for |
|
I don't see why the build is broken. Local build runs fine. Is it possible to restart the build?
|
|
Seems the Not sure how effective this would be though. |
I started the effort to localize the app. For whatever reason i don't understand the app wanted to have a DB version bump.
I tested it on emulator and a device.
There are a whole lot of duplicate words in the first step but i thought it would be easier to keep a naming scheme that is easy to understand then to remove duplicates and make it more complicated for everyone in the first place.
Getting rid of duplicates would be another step in this feature i think.