Use inner function to reduce boilerplate in LookAndFeelActivity #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
approved these changes
Jun 5, 2023
auto-merge was automatically disabled
June 5, 2023 19:41
Head branch was pushed to by a user without write access
twizmwazin
force-pushed
the
deduplicate-settings
branch
from
d8ce3bd to
ee6adda
Compare
twizmwazin
force-pushed
the
deduplicate-settings
branch
from
ee6adda to
d668558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
updateAppSettingsfunction to be an inner function ofLookAndFeelActivity. Now we don't have to pass every state object for every single settings entry.