Adjust the status bar while using the system dark theme to not use dark icons #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Apr 24, 2023
|
Ah, got it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed while using Jerboa that while my phone is using the dark theme, the status bar icons within the app are also dark which makes it seem a bit out of place. I'm opening this pull request to try to resolve this issue. I'm pretty new to the Jetpack Compose toolkit, so hopefully this approach looks appropriate. The following are screenshots from before and after to demonstrate the change:
Before:
After:
I tested this on my physical Pixel 6a running Android 13, however as a precaution I went ahead and also tested this on a virtual Pixel 3a running Android 11, just to make sure there were no introduced incompatibility changes.