Add api settings #183
Merged
Add api settings #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunaticHacker
force-pushed
the
settings
branch
5 times, most recently
from
531cc9c to
fdffe81
Compare
|
sorry for the force pushes, local linting doesn't pickup any codestyle errors is there some config file i need to add? |
|
You can just run |
dessalines
reviewed
Jul 12, 2022
app/src/main/java/com/jerboa/ui/components/settings/Settings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/settings/Settings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/settings/Settings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/settings/Settings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/settings/Settings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/settings/Settings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/jerboa/ui/components/settings/SettingsViewModel.kt
Show resolved
Hide resolved
dessalines
requested changes
Jul 13, 2022
|
Just add a few TODOs, but other than that, it looks good. |
dessalines
approved these changes
Jul 14, 2022
Now we just need to make this pretty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #88
for now this is just the api settings, we can add app-specific settings and account actions(password reset, account deletion) to this page in separate PRs