Restore legacy 'Show Scores' option #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also means show_scores was reset to false for pre 0.19.4 versions. As it used the wrong option. If users saved their settings in the meantime |
dessalines
reviewed
Jun 13, 2024
| @@ -144,52 +146,58 @@ fun ScoreAndTime( | |||
| downvotes = instantScores.downvotes, | |||
| ) | |||
|
|
|||
| // If the show_scores is disabled, and we are the instance is pre 0.19.4, we fallback to legacy behaviour | |||
| val version = API.getInstanceOrNull()?.version | |||
| val legacyScoresHidden = version != null && version < Version(0, 19, 4) && !voteDisplayMode.score | |||
There was a problem hiding this comment.
You can probably just use the !api.FF.hidePost() like in the other files, to denote that its before 0.19.4
| if (voteDisplayMode.score || voteDisplayMode.upvotes || voteDisplayMode.downvotes || voteDisplayMode.upvote_percentage) { | ||
| DotSpacer(style = MaterialTheme.typography.labelMedium) | ||
| if (!legacyScoresHidden) { | ||
| if (voteDisplayMode.score && !hideScore) { |
There was a problem hiding this comment.
You can just move !legacyScoresHidden into this if statement.
There was a problem hiding this comment.
I don't think so? It's previous behaviour was to hide all "voting types" , total, upvotes/downvotes. Current is to hide only scores. So to match previous behaviour this is necessary
dessalines
approved these changes
Jun 13, 2024
| if (voteDisplayMode.score || voteDisplayMode.upvotes || voteDisplayMode.downvotes || voteDisplayMode.upvote_percentage) { | ||
| DotSpacer(style = MaterialTheme.typography.labelMedium) | ||
| if (!legacyScoresHidden) { | ||
| if (voteDisplayMode.score && !hideScore) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy 'Show Scores' option was removed, this restores it.
This also fixes missing scores in listing view mode mode for pre 0.19.4 instances