Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Loading bar clipping behind content #1540

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jun 8, 2024

Fixes #1539

The MarkdownView seems to render later causing it, to be drawn over the loading bar. A simple zindex fixes this.

image

Also noticed this

This overload of AndroidView does not automatically pool or reuse Views. If placed inside of a reusable container (including inside a LazyRow or LazyColumn), the View instances will always be discarded and recreated if the composition hierarchy containing the AndroidView changes, even if its group structure did not change and the View could have conceivably been reused.
To opt-in for View reuse, call the overload of AndroidView that accepts an onReset callback, and provide a non-null implementation for this callback. Since it is expensive to discard and recreate View instances, reusing Views can lead to noticeable performance improvements — especially when building a scrolling list of AndroidViews. It is highly recommended to opt-in to View reuse when possible.
AndroidView will not clip its content to the layout bounds. Use View. setClipToOutline on the child View to clip the contents, if desired. Developers will likely want to do this with all subclasses of SurfaceView to keep its contents contained.

I'll play around with it when I have some time.

@MV-GH MV-GH requested a review from dessalines as a code owner June 8, 2024 11:41
@dessalines dessalines enabled auto-merge (squash) June 13, 2024 15:32
@dessalines dessalines disabled auto-merge June 13, 2024 15:45
@dessalines dessalines merged commit 9a7c7f8 into LemmyNet:main Jun 13, 2024
1 check passed
@MV-GH MV-GH deleted the bugfix/1539 branch June 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading bar overlap
2 participants