Adding LocalUserVoteDisplayMode for saving, and displaying votes. #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This uses the newly added field to LocalUserView above, to display votes according to your preferences. - Its also backward compatible, so if that setting is missing, it'll use Upvote + Downvote by default. - Fixes #1400
|
I should have time Wednesday to review this |
|
Cool, no rush. |
MV-GH
requested changes
Jun 6, 2024
app/src/main/java/com/jerboa/ui/components/settings/account/AccountSettings.kt
Outdated
Show resolved
Hide resolved
dessalines
commented
Jun 7, 2024
| } ?: run { | ||
| defaultMode | ||
| } | ||
| res.data.my_user?.local_user_view?.local_user_vote_display_mode ?: LocalUserVoteDisplayMode.default() |
There was a problem hiding this comment.
This one should be okay, because the default in your API is null.
MV-GH
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fullvote display mode? And what should be the default? #1400Samples: