Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alt_text and custom_thumbnail to post form. Fixes #1513 #1528

Merged
merged 3 commits into from
May 31, 2024

Conversation

dessalines
Copy link
Member

This adds the recently added alt_text and custom_thumbnail fields to creating and editing posts:

  • The alt_text field is only shown after you've added a url that's an image, matching lemmy-ui's behavior.
  • The postView.post.alt_text is now used as the contentDescription fields for pictrs images.
  • There might be some issues with custom_thumbnail, but that's a back-end problem still.

Example:

Record_2024-05-30-15-57-59.mp4

@dessalines dessalines requested a review from MV-GH as a code owner May 30, 2024 20:05
@dessalines dessalines marked this pull request as draft May 31, 2024 12:43
@dessalines dessalines marked this pull request as ready for review May 31, 2024 14:36
@dessalines dessalines merged commit e9fd30a into main May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants