-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework fontsize, better defaults #1452
Conversation
fun generateTypography(baseFontSize: Int): Typography { | ||
val customRatio = baseFontSize.toFloat() / COMPOSE_BODY_LARGE_DEFAULT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach does seem much simpler, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this, and it fixed the primary issue, and sizing works much better now. Thx!
@@ -811,3 +813,35 @@ fun ActionTopBar( | |||
}, | |||
) | |||
} | |||
|
|||
@Composable | |||
fun DualHeaderTitle( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for extracting this.
I made it scale with the ratio of the bodyLarge, meaning that if you set font size to 14 bodyLarge becomes 14.
And the other styles resize at the same ratio (14/16 = 87.5% size)
Fixes #1403
I am not done yet. But I recommend checking out if you see anything standing out. I made it so that most fields stay the same.