Swipe post/comment to upvote/downvote/reply/save #1327

Snow4DV · 2024-01-21T12:10:28Z

This feature will let user swipe to upvote/downvote posts/comments

Closes feature request #52

Currently it is WIP (implemented the composable that will wrap post/comment composables)

As default probably it would be better to set it up as "swipe to start - upvote, swipe to end - downvote" but this will affect "swipe to go back/to open drawer" gesture

Thinking about customization - how should it be implemented? Doing it straight-forward will add a lot of stuff to the settings entity (that is stored in room).

There are multiple ways:

Do a bunch of presets (it will limit the customization but it is the easiest one that won't affect the current settings structure a lot)
Create separate object for gestures preferences and convert it using the TypeConverter to json (with gson) when storing in room (4 lists of swipeactiontypes)
4 settings will be added (left/right gesture actions for posts/comments)
You tell me :)

dessalines · 2024-01-21T15:58:22Z

I wouldn't mind following the standard (I think @aeharding has with voyager):

Swipe right: Upvote, then downvote
Swipe left: Reply, then save/bookmark.

As far as customization, I really don't think we should add or try to maintain custom sets of actions. That would be immensely complicated and cumbersome to maintain. A simple boolean setting for swipe actions, default true, should work.

For colors: rather than gradients and fading, I'd just do static colors. And I'd much prefer using the already existing Material v3 colors: primary, secondary, tertiary. Make sure upvote and downvote colors match what those colors already are.

MV-GH · 2024-01-22T18:00:18Z

For custom actions I do have something proposed see #1318

As far as customization, I really don't think we should add or try to maintain custom sets of actions.

Am I missing something but too it seems we can achieve this rather simple with one enum describing the actions and have in appSettings these additional settings

val swipeLeftPostAction: Int,
val swipeRightPostAction: Int,
val tapCommentAction: Int,
val longTapCommentAction: Int,

Snow4DV · 2024-01-22T19:55:29Z

For custom actions I do have something proposed see #1318

As far as customization, I really don't think we should add or try to maintain custom sets of actions.

Am I missing something but too it seems we can achieve this rather simple with one enum describing the actions and have in appSettings these additional settings
val swipeLeftPostAction: Int,
val swipeRightPostAction: Int,
val tapCommentAction: Int,
val longTapCommentAction: Int,

More like 4 enums :)
one for short left swipe and one for long left swipe, same thing for right ones

Might also be good to add ability to keep all swipes on right side

I think it's not that important feature to make it fully-customizable. I might just create four presets (all actions on the left - all actions on the right - votes left, reply and save right - votes right, reply and save left. Easy to implement/maintain, will be enough for 99% of users

MV-GH · 2024-01-22T20:11:50Z

I saw it more as one enum with all these actions

that has different triggers

Snow4DV · 2024-01-22T20:19:24Z

I saw it more as one enum with all these actions

that has different triggers

Made a mistake in my previous comment, i meant four variables that would store enum.

That approach won't let you add four actions to one side (honestly i got used to this one because of sync) but might be more flexible to someone. idk then, maybe your approach is better, but won't matter to end user much any way :)

MV-GH · 2024-01-22T20:51:03Z

You mean like trigger that does both upvote and save?

…ization

Snow4DV · 2024-01-22T21:47:14Z

You mean like trigger that does both upvote and save?

That's how I see it:

Screenshot

Snow4DV · 2024-01-22T22:15:26Z

I wouldn't mind following the standard (I think @aeharding has with voyager):
* Swipe right: Upvote, then downvote

* Swipe left: Reply, then save/bookmark.
As far as customization, I really don't think we should add or try to maintain custom sets of actions. That would be immensely complicated and cumbersome to maintain. A simple boolean setting for swipe actions, default true, should work.

For colors: rather than gradients and fading, I'd just do static colors. And I'd much prefer using the already existing Material v3 colors: primary, secondary, tertiary. Make sure upvote and downvote colors match what those colors already are.

Used these colors for actions:

Upvote -> MaterialTheme.colorScheme.primary
Downvote -> MaterialTheme.colorScheme.tertiary
Reply -> MaterialTheme.colorScheme.onPrimary
Save -> MaterialTheme.colorScheme.onTertiary

About colors' transitions: there were no gradients but i used animateColorAsState to achieve smooth transition between two colors. Made it fast enough so it's not notable but improves overall experience

dessalines

I'll do a more thorough review of this later, but my biggest concerns are moving instant voting state out of the post listing. You could avoid that by passing that info up and down as needed.

Also try not to use Int for that settings preset, when you really want the Enum.

dessalines · 2024-01-22T23:11:14Z

app/src/main/java/com/jerboa/db/AppDB.kt

@@ -39,10 +39,11 @@ val APP_SETTINGS_DEFAULT =
        showPostLinkPreviews = true,
        postActionbarMode = 0,
        autoPlayGifs = false,
+        swipeToActionPreset = 1,


Use your setting Enum, and .ordinal .

dessalines · 2024-01-22T23:19:35Z

app/src/main/java/com/jerboa/feat/SwipeToAction.kt

+
+    companion object {
+        fun getActionToRangeList(actions: List<SwipeToActionType>): List<Pair<OpenEndRange<Float>, SwipeToActionType>> {
+            val delta = if (actions.size > 2) 0.14f else 0.18f


Not sure if here is where the issue is, but it switches from Upvote to Downvote way too quickly. Each action needs a longer swipe range (especially the first).

app/src/main/java/com/jerboa/ui/components/comment/CommentNodes.kt

dessalines · 2024-01-22T23:22:33Z

app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt

@@ -295,6 +298,17 @@ fun PostActivity(
                                    .testTag("jerboa:comments"),
                        ) {
                            item(key = "${postView.post.id}_listing", "post_listing") {
+                                val instantScores =


What's the reason these are getting moved around?

What's the reason these are getting moved around?

Honestly that wasn't my best approach, agree to that. Would be better to pass VoteType to child composables

app/src/main/res/values/strings.xml

Snow4DV · 2024-01-23T11:05:25Z

I'll do a more thorough review of this later, but my biggest concerns are moving instant voting state out of the post listing. You could avoid that by passing that info up and down as needed.

Also try not to use Int for that settings preset, when you really want the Enum.

I've spent a while thinking about a way to keep instantscores down in the composable hierarchy and the only one that comes to my mind (like passing channel to the child composable) will break the states go down - events go up principle. Modifying postview right away also doesn't look very good but it is possible if we pass it as state

i'm thinking about creating state object that holds postView and InstantScore objects and stores modified postview as state that holds correct my_vote, upvotes and downvotes count but there's a problem when child composable modifies vote and parent doesn't know anything about it

dessalines · 2024-01-26T01:43:12Z

@MV-GH would probably be able to give better guidance than I could... But I believe you could pass down the actions like swipeUpVote() -> Unit, and allow the instant scores state to be altered inside by those actions.

Snow4DV · 2024-01-29T20:58:39Z

I see that instantscores were refactored a little, finally got time, will take a look at it and improve according to new implementation.

Snow4DV · 2024-01-29T22:36:53Z

@MV-GH would probably be able to give better guidance than I could... But I believe you could pass down the actions like swipeUpVote() -> Unit, and allow the instant scores state to be altered inside by those actions.

Reimplemented it another way: just nested it inside single post's composable, should be fine, instantscore lays where it should now. Fixed the ranges also, you may have a look when you have time

MV-GH · 2024-01-30T22:40:41Z

I'll review it friday if it hasn't been reviewed by then.

app/src/main/java/com/jerboa/feat/SwipeToAction.kt

app/src/main/java/com/jerboa/ui/components/post/PostListing.kt

app/src/main/java/com/jerboa/ui/components/settings/lookandfeel/LookAndFeelActivity.kt

MV-GH · 2024-02-02T22:14:42Z

@dessalines also should this be enabled by default? I'll let you decide

MV-GH · 2024-02-03T18:47:08Z

app/src/main/java/com/jerboa/db/AppDBMigrations.kt

+    object : Migration(27, 26) {
+        override fun migrate(db: SupportSQLiteDatabase) {
+            db.execSQL(
+                "ALTER TABLE AppSettings DROP COLUMN swipe_to_action_preset",


android.database.sqlite.SQLiteException: near "DROP": syntax error (code 1 SQLITE_ERROR): , while compiling: ALTER TABLE AppSettings DROP COLUMN swipe_to_action_preset at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method) at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:1045)

It seems that DROP operations aren't supported

@dessalines should we remove all these downgrade migrations? They don't work anyway

Ooh. It's a surprise to me that SQLite doesn't support drop column in tables. It can be done via creating a separate table without that column (i looked into it and i guess that's how others do it)

I think separate PR should be created for downgrade migrations fix

yeah probably, but the down migrations aren't really used. So it won't be priority

Yeah its totally fine to remove them. One of the worst android bugs in existence: https://stackoverflow.com/questions/8045249/how-do-i-delete-column-from-sqlite-table-in-android

Snow4DV · 2024-02-04T18:06:03Z

Have a look at resolved comments. Fixed everything & also improved behaviour when account is not logged in (now it doesn't update instanceScore and still shows toast as intended).

About the latest comment: I think not working migrations should be left now so this could be improved in another pull request. This can be done by creating a separate table without newer column (see this)

app/src/main/java/com/jerboa/ui/components/common/SwipeToAction.kt

MV-GH

Other then that one remark its fine

MV-GH · 2024-02-04T23:52:09Z

for light theme, the white icon doesn't really work. You could add as black shim or use the color from the theme

studio64_4YKa6RD9e5.mp4

dessalines · 2024-02-05T03:21:39Z

Use one of the theme background colors, probably surface.

dessalines

Thx! Sry about my delay, I should be able to test again tmrw.

Snow4DV · 2024-02-05T10:39:18Z

Use one of the theme background colors, probably surface.

Surface color is already used by surface, so had to use something else. Had a problem with color collisions (error is tertiary when the theme is dark but reddish when it is light) so i used these colors to make them different and readable on light/dark themes:

@Composable
    fun getActionColor(): Color {
        return when (this) {
            Upvote -> MaterialTheme.colorScheme.secondary
            Downvote -> MaterialTheme.colorScheme.error
            Reply -> MaterialTheme.colorScheme.inversePrimary
            Save -> MaterialTheme.colorScheme.primary
        }
    }

Now upvote/downvote colors also match in light theme (didn't match previously)

Snow4DV · 2024-02-05T10:41:26Z

for light theme, the white icon doesn't really work. You could add as black shim or use the color from the theme
studio64_4YKa6RD9e5.mp4

I think white icons look good when they're placed on proper accent colors. Should be fine now (fixed theming when using both light/dark themes)

dessalines

Just tested, and it works really well! The colors look good to me, but we can always tweak them later.

The only issue I found: bookmarking / saving only works to save, but not to unsave it, unlike the button version.

You want to handle the conflicts, or should I?

Snow4DV · 2024-02-05T15:56:18Z

Just tested, and it works really well! The colors look good to me, but we can always tweak them later.

The only issue I found: bookmarking / saving only works to save, but not to unsave it, unlike the button version.

You want to handle the conflicts, or should I?

Totally missed it, happened due to lambda caching (it kept old instance of postView). Fixed that thing so now everything works correct

I resolved all conflicts so should be fine to merge now

dessalines

Sweet, thx!

* SwipeToAction composable * Swipe to downvote/upvote feature implemented with preset-based customization * Fix kotlin format * fix string resource * Do not use SwipeToAction when it is disabled * Improve scrolling experience * Increase color shift animation speed * Improve ranges * new preset: only votes * fix deltas & rename resources * SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges * Kotlin format * use ordinal of enum in AppDB instead of int * Fixed behaviour when downvotes disables/when not logged in * Fix formatting * Remove default param for enableDownVotes in SwipeToAction * Fix colors for swipe actions * Fixed lambda caching in rememberSwipeActionState * Format kotlin --------- Co-authored-by: Dessalines <[email protected]>

* Starting to work on registration applications. * Remove ImmutableList and add stability config file (#1342) * Adding admin / mod view votes. (#1331) * Starting to work on admin_view_votes, needs API added yet. * Finished up adding admin view votes. * Fix package name. * Upping lemmy-api version. * Adding a moderation subfield to post and comment action dropdowns. * Adding feature flag check. * Addressing PR comments. - Moving padding up to Box. - Using alternate feature flag method. * Temp workaround for compose-settings height bug. (#1345) - See alorma/Compose-Settings#203 - Fixes #1338 * Swipe post/comment to upvote/downvote/reply/save (#1327) * SwipeToAction composable * Swipe to downvote/upvote feature implemented with preset-based customization * Fix kotlin format * fix string resource * Do not use SwipeToAction when it is disabled * Improve scrolling experience * Increase color shift animation speed * Improve ranges * new preset: only votes * fix deltas & rename resources * SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges * Kotlin format * use ordinal of enum in AppDB instead of int * Fixed behaviour when downvotes disables/when not logged in * Fix formatting * Remove default param for enableDownVotes in SwipeToAction * Fix colors for swipe actions * Fixed lambda caching in rememberSwipeActionState * Format kotlin --------- Co-authored-by: Dessalines <[email protected]> * Almost finished viewmodel. * A few more additions. * Finishing up registration applications. * Adding a locally generated changelog. - Adds a last_version_code_viewed, that gets updated in the DB, and compared against the current version to show the changelog. This means we never have to manually update that column again. - Add a generate_changelog.sh script that uses git-cliff. It copies the changelog into code assets, which can be done before the release. - Fixes #1272 * Removing 27 schema * Removing 27 schema 2 * Moving changelog fetching to viewModel. * Persisting admin and mod status to DB. * Fixing format. * Removing weird changes. * Don't display bottomNav until acc loads * Fix formatting * Fix swapToAnon invalidating jwt + fix navbar not showing for anon --------- Co-authored-by: Maarten Vercruysse <[email protected]> Co-authored-by: Mikhail Loginov <[email protected]> Co-authored-by: maarten.vercruysse <[email protected]>

* Starting to work on registration applications. * Remove ImmutableList and add stability config file (#1342) * Adding admin / mod view votes. (#1331) * Starting to work on admin_view_votes, needs API added yet. * Finished up adding admin view votes. * Fix package name. * Upping lemmy-api version. * Adding a moderation subfield to post and comment action dropdowns. * Adding feature flag check. * Addressing PR comments. - Moving padding up to Box. - Using alternate feature flag method. * Temp workaround for compose-settings height bug. (#1345) - See alorma/Compose-Settings#203 - Fixes #1338 * Swipe post/comment to upvote/downvote/reply/save (#1327) * SwipeToAction composable * Swipe to downvote/upvote feature implemented with preset-based customization * Fix kotlin format * fix string resource * Do not use SwipeToAction when it is disabled * Improve scrolling experience * Increase color shift animation speed * Improve ranges * new preset: only votes * fix deltas & rename resources * SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges * Kotlin format * use ordinal of enum in AppDB instead of int * Fixed behaviour when downvotes disables/when not logged in * Fix formatting * Remove default param for enableDownVotes in SwipeToAction * Fix colors for swipe actions * Fixed lambda caching in rememberSwipeActionState * Format kotlin --------- Co-authored-by: Dessalines <[email protected]> * Almost finished viewmodel. * A few more additions. * Finishing up registration applications. * Adding a locally generated changelog. - Adds a last_version_code_viewed, that gets updated in the DB, and compared against the current version to show the changelog. This means we never have to manually update that column again. - Add a generate_changelog.sh script that uses git-cliff. It copies the changelog into code assets, which can be done before the release. - Fixes #1272 * Removing 27 schema * Removing 27 schema 2 * Adding the admin / mod report queue. * Moving changelog fetching to viewModel. * Persisting admin and mod status to DB. * Fixing format. * Removing weird changes. * Missed formatting. * Forgot to remove unused block. * Fixing missing fullBody. * Addressing PR comments. --------- Co-authored-by: Maarten Vercruysse <[email protected]> Co-authored-by: Mikhail Loginov <[email protected]>

Snow4DV and others added 2 commits January 21, 2024 01:45

SwipeToAction composable

b1ef785

Merge branch 'dessalines:main' into main

2d6c045

Merge branch 'dessalines:main' into main

65e94bb

Snow4DV and others added 5 commits January 23, 2024 00:22

Swipe to downvote/upvote feature implemented with preset-based custom…

109337d

…ization

Merge branch 'main' into main

e81c863

Fix kotlin format

edd1b7e

fix string resource

b121bd3

Do not use SwipeToAction when it is disabled

fabdd5c

Snow4DV marked this pull request as ready for review January 22, 2024 21:49

Snow4DV requested review from dessalines, twizmwazin and MV-GH as code owners January 22, 2024 21:49

Snow4DV added 2 commits January 23, 2024 01:08

Improve scrolling experience

899171c

Increase color shift animation speed

8a33f41

Improve ranges

38388da

dessalines reviewed Jan 22, 2024

View reviewed changes

new preset: only votes

30e807c

fix deltas & rename resources

ee9515e

Merge to upstream

d89d49d

use ordinal of enum in AppDB instead of int

23e8540

MV-GH requested changes Feb 2, 2024

View reviewed changes

MV-GH reviewed Feb 3, 2024

View reviewed changes

Snow4DV added 2 commits February 4, 2024 20:58

Fixed behaviour when downvotes disables/when not logged in

93e5c5e

Fix formatting

b5c0222

MV-GH reviewed Feb 4, 2024

View reviewed changes

app/src/main/java/com/jerboa/ui/components/common/SwipeToAction.kt Outdated Show resolved Hide resolved

MV-GH approved these changes Feb 4, 2024

View reviewed changes

Remove default param for enableDownVotes in SwipeToAction

8ac5f47

dessalines reviewed Feb 5, 2024

View reviewed changes

Fix colors for swipe actions

707990a

dessalines reviewed Feb 5, 2024

View reviewed changes

Snow4DV added 3 commits February 5, 2024 18:01

Fixed lambda caching in rememberSwipeActionState

b936b56

Merge to dessalines/jerboa (main)

5d677b8

Format kotlin

eed2dfd

dessalines approved these changes Feb 5, 2024

View reviewed changes

Merge branch 'main' into main

ceb18b3

dessalines enabled auto-merge (squash) February 5, 2024 19:08

dessalines merged commit fd42bb8 into LemmyNet:main Feb 5, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swipe post/comment to upvote/downvote/reply/save #1327

Swipe post/comment to upvote/downvote/reply/save #1327

Snow4DV commented Jan 21, 2024 •

edited

Loading

dessalines commented Jan 21, 2024 •

edited

Loading

MV-GH commented Jan 22, 2024

Snow4DV commented Jan 22, 2024 •

edited

Loading

MV-GH commented Jan 22, 2024

Snow4DV commented Jan 22, 2024 •

edited

Loading

MV-GH commented Jan 22, 2024

Snow4DV commented Jan 22, 2024 •

edited

Loading

Snow4DV commented Jan 22, 2024

dessalines left a comment •

edited

Loading

dessalines Jan 22, 2024

dessalines Jan 22, 2024

dessalines Jan 22, 2024

Snow4DV Jan 23, 2024

Snow4DV commented Jan 23, 2024 •

edited

Loading

dessalines commented Jan 26, 2024

Snow4DV commented Jan 29, 2024 •

edited

Loading

Snow4DV commented Jan 29, 2024

MV-GH commented Jan 30, 2024

MV-GH commented Feb 2, 2024

MV-GH Feb 3, 2024

Snow4DV Feb 4, 2024

MV-GH Feb 4, 2024

dessalines Feb 5, 2024

Snow4DV commented Feb 4, 2024

MV-GH left a comment

MV-GH commented Feb 4, 2024 •

edited

Loading

dessalines commented Feb 5, 2024

dessalines left a comment

Snow4DV commented Feb 5, 2024

Snow4DV commented Feb 5, 2024

dessalines left a comment

Snow4DV commented Feb 5, 2024

dessalines left a comment

Swipe post/comment to upvote/downvote/reply/save #1327

Swipe post/comment to upvote/downvote/reply/save #1327

Conversation

Snow4DV commented Jan 21, 2024 • edited Loading

dessalines commented Jan 21, 2024 • edited Loading

MV-GH commented Jan 22, 2024

Snow4DV commented Jan 22, 2024 • edited Loading

MV-GH commented Jan 22, 2024

Snow4DV commented Jan 22, 2024 • edited Loading

MV-GH commented Jan 22, 2024

Snow4DV commented Jan 22, 2024 • edited Loading

Snow4DV commented Jan 22, 2024

dessalines left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Snow4DV commented Jan 23, 2024 • edited Loading

dessalines commented Jan 26, 2024

Snow4DV commented Jan 29, 2024 • edited Loading

Snow4DV commented Jan 29, 2024

MV-GH commented Jan 30, 2024

MV-GH commented Feb 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Snow4DV commented Feb 4, 2024

MV-GH left a comment

Choose a reason for hiding this comment

MV-GH commented Feb 4, 2024 • edited Loading

dessalines commented Feb 5, 2024

dessalines left a comment

Choose a reason for hiding this comment

Snow4DV commented Feb 5, 2024

Snow4DV commented Feb 5, 2024

dessalines left a comment

Choose a reason for hiding this comment

Snow4DV commented Feb 5, 2024

dessalines left a comment

Choose a reason for hiding this comment

Snow4DV commented Jan 21, 2024 •

edited

Loading

dessalines commented Jan 21, 2024 •

edited

Loading

Snow4DV commented Jan 22, 2024 •

edited

Loading

Snow4DV commented Jan 22, 2024 •

edited

Loading

Snow4DV commented Jan 22, 2024 •

edited

Loading

dessalines left a comment •

edited

Loading

Snow4DV commented Jan 23, 2024 •

edited

Loading

Snow4DV commented Jan 29, 2024 •

edited

Loading

MV-GH commented Feb 4, 2024 •

edited

Loading