Add connect on matrix #1206
Merged
Add connect on matrix #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Aug 31, 2023
| @@ -278,6 +289,7 @@ fun PersonProfileMoreDropdown( | |||
| onBlockPersonClick: () -> Unit, | |||
| onReportPersonClick: () -> Unit, | |||
| onMessagePersonClick: () -> Unit, | |||
| openMatrix: (() -> Unit)?, | |||
There was a problem hiding this comment.
Hrm.... not a fan of optional params, as they often result in places you don't catch them. Probably best would be
hasMatrixId: Boolean,
onOpenMatrixClick: () -> Unit
There was a problem hiding this comment.
Optional params have indeed been a footgun but this param is not optional. You are forced to pass null or a lambda. Not doing will result in a compile error. That would not be the case if I did openMatrix: (() -> Unit)? = null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connect on matrix feature, this will open the relevant matrix client with the option to dm this user.
I designed the SVG icon of Matrix myself. So hereby I release the icon into the public domain
Edit:
Someone linked me a smaller icon, I am using that one now.