Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all relevant dialogs with Animated Center Popup menus #1200

Merged
merged 14 commits into from
Sep 4, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Aug 26, 2023

  • Replace More options dialog in home/community
  • Replace sort dialog home/community/post
  • Replace post more options
  • Replace comment more options
  • Replace CommentReply/CommentReply options
7lj0cKuGaq.mp4

Fixes #1065

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 29, 2023

I fixed the original color issue, still waiting for upstream to include the fixes. In the mean time I am attempting to create a centered menu with animations but it is jittery

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 29, 2023

nK6JrdFmYj.mp4

@dessalines
Copy link
Member

This looks like a ton of custom code for something that google should have implemented in a simple way. Might even be worth checking out if someone's made a compose plugin for it.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 29, 2023

That custom code is a external compose lib https://github.com/saket/cascade. It just had my fixes and possible custom impl derived from it

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 30, 2023

Starting to look good

cot8LTIDkF.mp4

@dessalines
Copy link
Member

Nice, yeah it does look good. I see you have one open PR on cascade, but maybe it would be better to add your other customizations to it as PRs, (and any type of generalizations you have in that cascade/internal folder). Then others would benefit from it, and that custom code wouldn't live in jerboa anymore.

@MV-GH MV-GH changed the title Add full more options M3 dialog Replace all relevant dialogs with Animated Center Popup menus Aug 30, 2023
@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 31, 2023

I am not sure if upstream would want these changes. I'll make a issue to inquire about it.

The pr is ready btw

@MV-GH MV-GH marked this pull request as ready for review August 31, 2023 00:09
Copy link
Contributor

@twizmwazin twizmwazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good!

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I'll approve, but if you can always try to upstream additions to these libraries first, so that other projects can take advantage of the customizations. If we find it useful, other people likely would too.

@dessalines dessalines merged commit b0dbdef into LemmyNet:main Sep 4, 2023
@MV-GH MV-GH deleted the feat/more_options_dialog_change branch September 4, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all relevant dialogs with M3 menus (Such as Sort/More options/post more options)
3 participants