-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all relevant dialogs with Animated Center Popup menus #1200
Replace all relevant dialogs with Animated Center Popup menus #1200
Conversation
I fixed the original color issue, still waiting for upstream to include the fixes. In the mean time I am attempting to create a centered menu with animations but it is jittery |
nK6JrdFmYj.mp4 |
This looks like a ton of custom code for something that google should have implemented in a simple way. Might even be worth checking out if someone's made a compose plugin for it. |
That custom code is a external compose lib https://github.com/saket/cascade. It just had my fixes and possible custom impl derived from it |
Starting to look good cot8LTIDkF.mp4 |
Nice, yeah it does look good. I see you have one open PR on cascade, but maybe it would be better to add your other customizations to it as PRs, (and any type of generalizations you have in that cascade/internal folder). Then others would benefit from it, and that custom code wouldn't live in jerboa anymore. |
# Conflicts: # app/src/main/res/values/strings.xml
I am not sure if upstream would want these changes. I'll make a issue to inquire about it. The pr is ready btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I'll approve, but if you can always try to upstream additions to these libraries first, so that other projects can take advantage of the customizations. If we find it useful, other people likely would too.
7lj0cKuGaq.mp4
Fixes #1065