Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community block msg to display unblock if blocked already #1185

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Aug 17, 2023

  • Made text not hardcoded anymore
  • Display error on failure to block
  • Update view to show unblock if community is blocked
studio64_VTpIBvNNE7.mp4

I tried to do the same for postlistings but PostView does not contain a field for blocked community and mapping it to a datatype that does contain it pretty complex and could be done easier when the API rework gets done.
Also see LemmyNet/lemmy#3885

@dessalines
Copy link
Member

I spose this is okay to add, but its still fairly pointless, because once you refresh the content or navigate away, you won't see the content to be able to unblock it. This is why in lemmy-ui, unblocking communities and persons are a section of your user settings.

@dessalines dessalines merged commit 014582c into LemmyNet:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants