Fix comment click deadzones #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to make selections on comment source.
camporter
requested review from
dessalines,
twizmwazin and
MV-GH
as code owners
camporter
commented
Aug 12, 2023
| }, | ||
| ) | ||
| Spacer(modifier = Modifier.height(MEDIUM_PADDING)) |
There was a problem hiding this comment.
The combination of this unclickable spacer and the modifier with unclickable padding on the footer line below seems to have been a deadzone when clicking to collapse comments.
MV-GH
reviewed
Aug 12, 2023
app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt
Outdated
Show resolved
Hide resolved
|
Can you also change that the View Source text changes to View original after it is clicked like it does with the post |
… comment text and the source text.
|
I was avoiding touching the dialogs 😄 updated now. |
MV-GH
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes it easier to make selections on comment source, and source now shows in monospace.
Screen_recording_20230812_000054.webm