Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post actionbar design rework and options for it. #1155

Merged
merged 14 commits into from
Aug 8, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Aug 7, 2023

Fixes #639

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

258817525-d46a72ea-0a15-49bc-8a44-802d55a0e207

To

(Only comment text changes)

258831200-418b565d-3ea8-49c7-87ad-ebd660c9a649

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

Rearrange footing + change icons

short form (note on a instance with downvotes disabled)

258850794-9408a33a-0c50-4c98-b3f3-2b616122b83f

Long form, Im leaning for this rn

image

(Above but in post mode)

image

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

I'm thinking of making the post actionbar looks an option: (default long form), lefthand shortmode, righthand shortmode

@dessalines
Copy link
Member

I like that a lot, IE the +6 , with the badge, plus, and italics inline.

I'd def prefer the vote buttons stay on the right side, to the right of the comment icon and counts, at least until a left-handed mode is added.

Either comments icon looks good to me.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

studio64_vf2wZzJSfE.mp4

Added the post actionbar mode settings. Do you still prefer comment to be to the left? @dessalines

@dessalines
Copy link
Member

That looks good, except that the short righthand should probably still left-align the comment info. Most of this was taken from boost, which looks like this:

Screenshot_2023-08-07-15-16-30-700_com rubenmayayo reddit

If that's not doable tho, or would overly-complicate the code, it'd be fine to right-align everything tho.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

image

Not that complex to implement. The lefthandside stays the same?
@dessalines

@dessalines
Copy link
Member

Nice, that looks great!

Ya, the left-hand can stay the same.

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

Alright, I posted it in the community. We ll see feedback then this can be merged

@MV-GH MV-GH changed the title [FEEDBACK NEEDED] Footbar post listing actions design rework Post actionbar design rework and options for it. Aug 8, 2023
@MV-GH MV-GH marked this pull request as ready for review August 8, 2023 13:02
import com.jerboa.R

enum class PostActionbarMode(@StringRes val resId: Int) {
LeftHandShort(R.string.post_actionbar_mode_short_left),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be RightHandShort first.

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx. I'll try to get this released today.

@dessalines dessalines enabled auto-merge (squash) August 8, 2023 16:30
@dessalines dessalines merged commit 51b6c0a into LemmyNet:main Aug 8, 2023
@MV-GH MV-GH deleted the feat/appbar_rework branch August 8, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action Bar Buttons get pushed off screen when comment count is too high
3 participants