-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post actionbar design rework and options for it. #1155
Conversation
I'm thinking of making the post actionbar looks an option: (default long form), lefthand shortmode, righthand shortmode |
# Conflicts: # app/src/main/res/values/strings.xml
studio64_vf2wZzJSfE.mp4Added the post actionbar mode settings. Do you still prefer comment to be to the left? @dessalines |
Not that complex to implement. The lefthandside stays the same? |
Nice, that looks great! Ya, the left-hand can stay the same. |
Alright, I posted it in the community. We ll see feedback then this can be merged |
app/src/main/java/com/jerboa/ui/components/settings/lookandfeel/LookAndFeelActivity.kt
Outdated
Show resolved
Hide resolved
import com.jerboa.R | ||
|
||
enum class PostActionbarMode(@StringRes val resId: Int) { | ||
LeftHandShort(R.string.post_actionbar_mode_short_left), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be RightHandShort first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thx. I'll try to get this released today.
Fixes #639