Add strings for the validateUrl and validatePostName utils. #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camporter
requested review from
dessalines,
twizmwazin and
MV-GH
as code owners
twizmwazin
suggested changes
Aug 7, 2023
app/src/main/res/values/strings.xml
Outdated
| @@ -303,7 +303,13 @@ | |||
| <string name="sorttype_topweek">TopWeek</string> | |||
| <string name="sorttype_topyear">TopYear</string> | |||
| <string name="time_ago_ago">%1$s %2$s ago</string> | |||
| <string name="title">Title</string> | |||
| <string name="title_less_than_200_chars">Title cannot be > 200 chars</string> | |||
There was a problem hiding this comment.
Title cannot be more than 200 characters
app/src/main/res/values/strings.xml
Outdated
| @@ -303,7 +303,13 @@ | |||
| <string name="sorttype_topweek">TopWeek</string> | |||
| <string name="sorttype_topyear">TopYear</string> | |||
| <string name="time_ago_ago">%1$s %2$s ago</string> | |||
| <string name="title">Title</string> | |||
| <string name="title_less_than_200_chars">Title cannot be > 200 chars</string> | |||
| <string name="title_min_3_chars">"Title must be at least 3 chars</string> | |||
There was a problem hiding this comment.
Title must be at least three characters Also note the extra double quote
app/src/main/res/values/strings.xml
Outdated
| <string name="topAppBar_back">Back</string> | ||
| <string name="url">Url</string> |
There was a problem hiding this comment.
URL, also capitalize below
camporter
force-pushed
the
url_and_title_util_strings
branch
from
18ebe6e to
15c4f33
Compare
MV-GH
approved these changes
Aug 7, 2023
twizmwazin
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1129
Pulls in Mockito. I'm not sure what the feeling about doing so is.
Just wanted to be able to keep the tests while also mocking
Contextout.