Add direct message person option and screen #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV-GH
changed the title
twizmwazin
reviewed
Jul 28, 2023
app/src/main/res/values/strings.xml
Outdated
| @@ -347,4 +347,8 @@ | |||
| <string name="failed_saving_image">Failed to save image!</string> | |||
| <string name="home_switch_anon">Switch to anonymous</string> | |||
| <string name="login_already_logged_in">You are already logged in with this account</string> | |||
| <string name="person_profile_dm_person">Message this person</string> | |||
There was a problem hiding this comment.
Message <username> is preferable
There was a problem hiding this comment.
It's because the other two options are X this person
There was a problem hiding this comment.
Message <username> can get possibly pretty long depending on the username, what about Send a message ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a bug where it shows all the more options in the dialog for non logged in users and all those option need the user to be logged in.
studio64_wtS5ZS54pR.mp4