New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `Value X cannot be converted to json` in error messages #1098

Merged

dessalines merged 1 commit into LemmyNet:main from MV-GH:fix/cannot_convert_json

Jul 27, 2023

Collaborator

MV-GH commented Jul 25, 2023 •

edited

Loading

Fixes these

Currently it always assumes that when the response fails that it gets a JSON error object. Which we frequently don't.

So this will make timeout errors and others show nicely

Fixes #1005


          Prevent Value X cannot be converted from showing

f756dc1

MV-GH requested review from dessalines and twizmwazin as code owners

July 25, 2023 18:25

MV-GH changed the title ~~Fix Value X cannot be converted~~ Fix Value X cannot be converted to json in error messages

dessalines approved these changes

View reviewed changes

dessalines merged commit 5119b55 into LemmyNet:main

MV-GH deleted the fix/cannot_convert_json branch

July 27, 2023 17:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet