Prevent duplicate accounts from logging in #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV-GH
commented
Jul 21, 2023
There was a problem hiding this comment.
How does this section prevent logging in with a non supported account?
if (compareVersions(siteVersion, MINIMUM_API_VERSION) < 0) {
val message = ctx.resources.getString(
R.string.dialogs_server_version_outdated_short,
siteVersion,
)
Toast.makeText(ctx, message, Toast.LENGTH_SHORT).show()
}Hmm this related #931 ?
twizmwazin
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987
studio64_9HEnXRyEi4.mp4
I used name + instance to define duplicate because person.Id could be duplicate for two separate accounts on different instances.
I do feel like this whole login function with its numerous changeLemmyInstances should be refactored to use createTempInstance and only be swapped on login.