Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unread inbox counter badge not properly updating #1051

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Fix unread inbox counter badge not properly updating #1051

merged 6 commits into from
Jul 18, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 16, 2023 •
edited
Loading

  • Fixes the fetches not being done after the markReadChange
  • Missing fetch on opening inbox
  • Made readUncount a state, so that changes cause recompositions.
qY7lwl5lp5.mp4

Fixes #1039

@MV-GH MV-GH requested a review from dessalines July 17, 2023 18:38
@dessalines dessalines merged commit 455e89a into LemmyNet:main Jul 18, 2023
@MV-GH MV-GH deleted the bug/1039 branch July 18, 2023 15:17
@ZJouba ZJouba mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twizmwazin twizmwazin twizmwazin approved these changes

@dessalines dessalines dessalines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read notifications do not disappear when clicking the double checkmark icon.
3 participants
@MV-GH @dessalines @twizmwazin