Improve stableness #1040
Merged
Improve stableness #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/jerboa/MainActivity.kt # app/src/main/java/com/jerboa/ui/components/community/CommunityActivity.kt # app/src/main/java/com/jerboa/ui/components/home/BottomNavActivity.kt # app/src/main/java/com/jerboa/ui/components/home/HomeActivity.kt # app/src/main/java/com/jerboa/ui/components/person/PersonProfileActivity.kt # app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt # app/src/main/java/com/jerboa/ui/components/post/PostListing.kt # app/src/main/java/com/jerboa/ui/components/post/create/CreatePostActivity.kt
dessalines
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Tested, and this works well. Thx especially for moving the navcontroller out of the composables.
I'll let @twizmwazin look this over before merging.
| @@ -33,7 +31,7 @@ class LoginViewModel : ViewModel() { | |||
| fun login( | |||
| instance: String, | |||
| form: Login, | |||
| navController: NavController, | |||
| onGoHome: () -> Unit, | |||
There was a problem hiding this comment.
Gotcha, that's unfortunate that the navController can't be passed down and causes rerenders. But I like how you've done this, its cleaner anyway.
twizmwazin
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve stableness of many composables. The root cause is navHostController. It is considered unstable
"skippableComposables": 549, -> 582
"knownUnstableArguments": 393, ->234
examples of before
after
Metrics files
compose_metrics_old.zip
compose_metrics.zip
Also redid the baseline profiles
I have still many ideas, but I ll keep those for other PRs. This one is big enough already.