Add option to show/hide post previews #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can't view these images, I get this |
|
I think this is better named post link preview. Not to be confused with post markdown body preview. |
|
Another option we can look into is, automatically hide the meta description if its the same as the meta title, and the meta title if its the same as the post title. |
MV-GH
approved these changes
Jul 14, 2023
dessalines
approved these changes
Jul 14, 2023
| @@ -429,7 +430,7 @@ fun PostBody( | |||
| ) | |||
|
|
|||
| // The metadata card | |||
| if (fullBody && post.embed_title !== null) { | |||
| if (fullBody && showPostLinkPreview && post.embed_title !== null) { | |||
There was a problem hiding this comment.
Ohh okay this is about the metadata cards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an issue somewhere someone suggested that titles and bodies were being duplicated when it was actually just that the user copied the title and article description into their post. I thought maybe adding an option to disable the preview would be a good idea.
When enabled/current behavior:
After with disabled:
