Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of show_parent_comment_navigation_buttons #1027

Merged
merged 6 commits into from
Jul 13, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 12, 2023

Doing it this way, wont affect existing users, just new install and new users migrating from a older install

@MV-GH MV-GH marked this pull request as draft July 12, 2023 19:18
@MV-GH
Copy link
Collaborator Author

MV-GH commented Jul 12, 2023

Nvm room doesnt play nice

  Caused by: java.lang.IllegalStateException: Room cannot verify the data integrity. Looks like you've changed schema but forgot to update the version number. You can simply fix this by increasing the version number. Expected identity hash: ad45348d127850603284a08efa23652a, found: 48a7d36d42e1a9901e39fcb739f396f7

Sadly sqllite doesnt have a each way to change the default of a column, only way is to drop whole table and recreate. This is of course not wanted at all.

Any ideas?

@twizmwazin
Copy link
Contributor

@MV-GH MV-GH marked this pull request as ready for review July 12, 2023 20:13
@MV-GH MV-GH enabled auto-merge (squash) July 13, 2023 11:07
@MV-GH MV-GH merged commit 54886b3 into LemmyNet:main Jul 13, 2023
@MV-GH MV-GH deleted the feat/change_default branch July 13, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants