-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown preview #1002
Merged
Merged
Add markdown preview #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… card & small card
# Conflicts: # app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt
dessalines
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works great. Thx!
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed up #734
It has one slight issue that i have been unable to fix after many attempts. If it is a dealbreaker someone else will have to solve this. Basically texts longer than 5 lines are "scrollable". They don't get truncated to 5 lines. But you can only scroll them using links. Maybe if you disable linkmovementmethod you can solve that. But it doesn't solve the root problem that it doesn't actually truncate the long text.
studio64_zKQUktAuNv.mp4
This doesn't seem to do anything but where attempts for possible fix. I kept them to highlight some things I have tried. Can be removed.