Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of showing Score, Upvote, and Downvote, show only Score and Upvote Percentage (or sentiment icon) #1372

Open
3 tasks done
dessalines opened this issue Feb 12, 2024 · 8 comments
Labels
3 - medium priority This issue needs to be considered, but may not be a priority for the next release enhancement New feature or request

Comments

@dessalines
Copy link
Member

dessalines commented Feb 12, 2024

Pre-Flight checklist

  • Did you check to see if this issue already exists?
  • This is a single feature request. (Do not put multiple feature requests in one issue)
  • This is not a question or discussion. (Use https://lemmy.ml/c/jerboa for that)

Describe The Feature Request Below

@MV-GH I'd like your feedback before I start working on this.

Currently, on every post / comment, we show 3 pieces of info:

  • A score in the header bar
  • Upvote and downvote count in the footer / action bar.

Sample:

Screenshot_2024-02-12-12-52-32-271-edit_com jerboa_1

This is kind of a lot of mostly redundant info.

It'd be nice to simplify this (like some other apps I've seen), and show only

  • A score and an upvote percentage in the header bar.
    • We could also hide the upvote percentage if its above a certain threshold (IE 80% liked)
    • And instead of a percentage number, we could show one of these sentiment icons

This would move the pieces of info shown from 3 down to 2 (or 1 if its a well liked item).

@dessalines dessalines added enhancement New feature or request 3 - medium priority This issue needs to be considered, but may not be a priority for the next release labels Feb 12, 2024
@MV-GH
Copy link
Collaborator

MV-GH commented Feb 12, 2024

I am open for this, but I would lean on making this a setting at first. Also I prefer percentage (Hide this if its 95%+)

@dessalines
Copy link
Member Author

Sounds good, I think I prefer the percentage also.

@dessalines
Copy link
Member Author

I've decided that this is a pervasive enough setting that it should probably live in the back-end.

I can implement this before we add that back-end setting referenced above, by using a dummy setting.

@MV-GH
Copy link
Collaborator

MV-GH commented Feb 12, 2024

We are gonna need something dummy regardless for backwards compatibility :/

Lemmy.world is not even on 0.19 yet so the backwards compatibility is still pretty important.

or for Lemmy version which don't implement that feature yet, we can just assume they want the old behaviour and only make the setting available for instances that support the feature

@dessalines
Copy link
Member Author

dessalines commented Feb 12, 2024

For sure, mainly I just want to hold off on adding a DB migration in jerboa, and instead make this a back-end user setting.

EDIT: errr scratch that. It might be a while till we deploy that new feature anyway. So maybe I will add an app-specific setting, then eventually disregard it.

@MV-GH
Copy link
Collaborator

MV-GH commented Feb 12, 2024

Isn't this then a setting on Acccount too? like listing etc

@dessalines
Copy link
Member Author

dessalines commented Feb 13, 2024

Yep, I imagine it would be good to persist there also, just like default_post_listing_type, etc. But the true source value will be from the back-end.

We should also do this for the new PostListingMode setting, and move that one out of the app settings.

@MV-GH
Copy link
Collaborator

MV-GH commented Feb 13, 2024

Ah that was added for 0.19. For 0.18 we use account, as source of truth then

dessalines added a commit that referenced this issue Feb 14, 2024
- Also removing redundant score counts from comment and post footers.
- Context: #1372
dessalines added a commit that referenced this issue Feb 23, 2024
* Adding additional vote display modes

- Also removing redundant score counts from comment and post footers.
- Context: #1372

* Adding a threshold.

* Using label for comment count.

* Refactor to pass in instantscores.

* Fixing format percent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - medium priority This issue needs to be considered, but may not be a priority for the next release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants