-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instead of showing Score, Upvote, and Downvote, show only Score and Upvote Percentage (or sentiment icon) #1372
Comments
I am open for this, but I would lean on making this a setting at first. Also I prefer percentage (Hide this if its 95%+) |
Sounds good, I think I prefer the percentage also. |
I've decided that this is a pervasive enough setting that it should probably live in the back-end. I can implement this before we add that back-end setting referenced above, by using a dummy setting. |
We are gonna need something dummy regardless for backwards compatibility :/ Lemmy.world is not even on 0.19 yet so the backwards compatibility is still pretty important. or for Lemmy version which don't implement that feature yet, we can just assume they want the old behaviour and only make the setting available for instances that support the feature |
For sure, mainly I just want to hold off on adding a DB migration in jerboa, and instead make this a back-end user setting. EDIT: errr scratch that. It might be a while till we deploy that new feature anyway. So maybe I will add an app-specific setting, then eventually disregard it. |
Isn't this then a setting on Acccount too? like listing etc |
Yep, I imagine it would be good to persist there also, just like We should also do this for the new PostListingMode setting, and move that one out of the app settings. |
Ah that was added for 0.19. For 0.18 we use account, as source of truth then |
- Also removing redundant score counts from comment and post footers. - Context: #1372
* Adding additional vote display modes - Also removing redundant score counts from comment and post footers. - Context: #1372 * Adding a threshold. * Using label for comment count. * Refactor to pass in instantscores. * Fixing format percent.
Pre-Flight checklist
Describe The Feature Request Below
@MV-GH I'd like your feedback before I start working on this.
Currently, on every post / comment, we show 3 pieces of info:
Sample:
This is kind of a lot of mostly redundant info.
It'd be nice to simplify this (like some other apps I've seen), and show only
This would move the pieces of info shown from 3 down to 2 (or 1 if its a well liked item).
The text was updated successfully, but these errors were encountered: