Making icons larger, adding node keys

- Fixes #336 - Fixes #337
LemmyNet · Feb 20, 2023 · fb6a692 · fb6a692
1 parent 23faeca
commit fb6a692
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt b/app/src/main/java/com/jerboa/ui/components/comment/CommentNode.kt
@@ -180,7 +180,7 @@ fun LazyListScope.commentNodeItem(
 
     val showMoreChildren = isExpanded(commentId) && node.children.isNullOrEmpty() && node
         .commentView.counts.child_count > 0 && !isFlat
-    item {
+    item(key = commentId) {
         var viewSource by remember { mutableStateOf(false) }
 
         val backgroundColor = MaterialTheme.colorScheme.background
@@ -279,7 +279,7 @@ fun LazyListScope.commentNodeItem(
     }
 
     if (showMoreChildren) {
-        item {
+        item(key = "${commentId}_children") {
             ShowMoreChildrenNode(node.depth, commentView, onFetchChildrenClick)
         }
     }

diff --git a/app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt b/app/src/main/java/com/jerboa/ui/components/post/PostActivity.kt
@@ -116,7 +116,7 @@ fun PostActivity(
                         modifier = Modifier.padding(padding)
                             .simpleVerticalScrollbar(listState)
                     ) {
-                        item {
+                        item(key = "${postView.post.id}_listing") {
                             PostListing(
                                 postView = postView,
                                 onUpvoteClick = {
@@ -201,7 +201,7 @@ fun PostActivity(
                                 postViewMode = PostViewMode.Card
                             )
                         }
-                        item {
+                        item(key = "${postView.post.id}_is_comment_view") {
                             if (postViewModel.isCommentView()) {
                                 postViewModel.postView.value?.post?.id?.let { postId ->
                                     ShowCommentContextButtons(

diff --git a/app/src/main/java/com/jerboa/ui/theme/Sizes.kt b/app/src/main/java/com/jerboa/ui/theme/Sizes.kt
@@ -11,8 +11,8 @@ val XL_PADDING = 16.dp
 val XXL_PADDING = 20.dp
 val XXXL_PADDING = 24.dp
 
-val ICON_SIZE = 24.dp
-val MEDIUM_ICON_SIZE = 48.dp
+val ICON_SIZE = 36.dp
+val MEDIUM_ICON_SIZE = 64.dp
 val LARGER_ICON_SIZE = 80.dp
 val DRAWER_BANNER_SIZE = 96.dp
 val PROFILE_BANNER_SIZE = 128.dp