chore: Update eslint „quotes“ rule

Since typescript-eslint/typescript-eslint#762 is published the normal quotes rule can be disabled and the typescript one activated. This allows me to use backticks, but they won’t get added to types (they are not valid there)
LekoArts · Sep 11, 2019 · e9e75cb · e9e75cb
1 parent 796180c
commit e9e75cb
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 18 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -44,6 +44,14 @@ module.exports = {
         "allowTaggedTemplates": true
       }
     ],
+    quotes: "off",
+    "@typescript-eslint/quotes": [
+      2,
+      "backtick",
+      {
+        "avoidEscape": true
+      }
+    ],
     "@typescript-eslint/prefer-interface": 0,
     "@typescript-eslint/explicit-function-return-type": 0,
     "@typescript-eslint/no-use-before-define": 0,
@@ -83,13 +91,6 @@ module.exports = {
     ],
     "react-hooks/rules-of-hooks": "error",
     "react-hooks/exhaustive-deps": "warn",
-    quotes: [
-      2,
-      "backtick",
-      {
-        "avoidEscape": true
-      }
-    ],
     indent: ["error", 2, { SwitchCase: 1 }],
     "prettier/prettier": [
       "error",

diff --git a/themes/gatsby-theme-cara/src/components/svg.tsx b/themes/gatsby-theme-cara/src/components/svg.tsx
@@ -67,8 +67,6 @@ const icons = {
   },
 }
 
-// TODO: https://github.com/typescript-eslint/typescript-eslint/pull/762 Change quotes setup so that type can also use double quotes
-// eslint-disable-next-line
 type IconType = "triangle" | "circle" | "arrowUp" | "upDown" | "box" | "hexa" | "cross"
 
 type SVGProps = {

diff --git a/themes/gatsby-theme-specimens/src/components/alert.tsx b/themes/gatsby-theme-specimens/src/components/alert.tsx
@@ -7,9 +7,7 @@ import Announcement from "../icons/announcement"
 import Info from "../icons/info"
 import Important from "../icons/important"
 
-// TODO: https://github.com/typescript-eslint/typescript-eslint/pull/762 Change quotes setup so that type can also use double quotes
-// eslint-disable-next-line
-type AlertTypes = 'success' | 'hint' | 'warning' | 'info' | 'danger'
+type AlertTypes = "success" | "hint" | "warning" | "info" | "danger"
 
 type AlertProps = {
   children: React.ReactNode

diff --git a/themes/gatsby-theme-specimens/src/components/palette.tsx b/themes/gatsby-theme-specimens/src/components/palette.tsx
@@ -6,9 +6,7 @@ import ColorRow from "./color-row"
 
 const join = (...args: any) => args.filter(Boolean).join(`.`)
 
-// TODO: https://github.com/typescript-eslint/typescript-eslint/pull/762 Change quotes setup so that type can also use double quotes
-// eslint-disable-next-line
-type ModeTypes = 'list' | 'swatch'
+type ModeTypes = "list" | "swatch"
 
 type PaletteProps = {
   colors: {

diff --git a/themes/gatsby-theme-specimens/src/hooks/useSpecimensConfig.tsx b/themes/gatsby-theme-specimens/src/hooks/useSpecimensConfig.tsx
@@ -1,8 +1,6 @@
 import { useStaticQuery, graphql } from "gatsby"
 
-// TODO: https://github.com/typescript-eslint/typescript-eslint/pull/762 Change quotes setup so that type can also use double quotes
-// eslint-disable-next-line
-type ContrastTypes = 'AA' | 'AAA'
+type ContrastTypes = "AA" | "AAA"
 
 type specimensOptionsType = {
   specimensConfig: {