Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more error code for the rvvm_attach_mmio #72

Merged
merged 2 commits into from Dec 29, 2022
Merged

Add one more error code for the rvvm_attach_mmio #72

merged 2 commits into from Dec 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2022

  • Introduce new error code: RVVM_VM_IS_RUNNING_ERR for the rvvm_attach_mmio API function
  • Add important information in the rvvm_attach_mmio's documentation.

@LekKit LekKit merged commit 09e2f8c into LekKit:staging Dec 29, 2022
@X547
Copy link
Contributor

X547 commented Dec 30, 2022

So no hotplug?

@ghost
Copy link
Author

ghost commented Dec 30, 2022

So no hotplug?

What do you mean?

@X547
Copy link
Contributor

X547 commented Dec 30, 2022

Ability to add new MMIO devices at runtime when VM is running.

@ghost
Copy link
Author

ghost commented Dec 30, 2022

Ability to add new MMIO devices at runtime when VM is running.

Uh, sorry, didn't understood you at the first glance. I'll try to discuss about it with the repository owner.

@LekKit
Copy link
Owner

LekKit commented Dec 30, 2022

So no hotplug?

There may be, but no busses allow such behavior at the moment. We also need to gracefuly park CPU threads before manipulating device lookup list (Easy to do).

MMIO devices are baked into FDT and hardwired to the SoC, PCIe hotplug isn't implemented (yet). Other types of busses (I2C) are OK but they are unrelated to mmio subsystem.

What are your wanted usecases for hotplug? I could think of dynamic drive attach

@LekKit
Copy link
Owner

LekKit commented Dec 30, 2022

For testing PCIe hotplug I'd really like to have a working physical board with that, and my VF2 is yet to arrive...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants