fix some todos #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When merging maybe do a squash merge :-) |
Leinnan
reviewed
Aug 25, 2024
| @@ -27,22 +27,11 @@ jobs: | |||
| timeout-minutes: 60 | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/cache@v4 | |||
Leinnan
reviewed
Aug 25, 2024
| @@ -1,9 +0,0 @@ | |||
| extern crate embed_resource; | |||
There was a problem hiding this comment.
About this file - without it, executable will not have an icon on Windows.
There was a problem hiding this comment.
but it was never triggered...
build.rs must be set in Cargo.toml - I will rereview that later on
|
Yeaahh a squash merge would be better or i squash all commits before you merge - this is a mess xD |
Leinnan
requested changes
Aug 25, 2024
Cargo.toml
Outdated
| @@ -2,6 +2,7 @@ | |||
| name = "lwa_fm" | |||
| edition = "2021" | |||
| homepage = "https://github.com/Leinnan/lwa_fm" | |||
| build = "build.rs" | |||
There was a problem hiding this comment.
Okay, now I get it. If you create build.rs it will be used and there is no need to specify it in Cargo.toml. This field is when you want to use different path than REPO_ROOT/build.rs. So setting up it to default value add no value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.