Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract swap parameters from deeplink #9214

Merged

Conversation

ejaycoleman
Copy link
Contributor

@ejaycoleman ejaycoleman commented Feb 13, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Extracts Swap parameters amountFrom, fromToken and toToken from ledgerlive://swap deeplinks

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 11:35am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 11:35am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 11:35am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 11:35am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 13, 2025
@ejaycoleman ejaycoleman changed the title feat(LIVE-17004) extract swap parameters from deeplink feat: extract swap parameters from deeplink Feb 13, 2025
@ejaycoleman ejaycoleman marked this pull request as ready for review February 13, 2025 11:28
@ejaycoleman ejaycoleman requested a review from a team as a code owner February 13, 2025 11:28
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me with the amount but the from and to token are wrong:

SwapDeeplink.mov

@ejaycoleman
Copy link
Contributor Author

@thesan Have you got multiple accounts? This currently only works when there is one account per token (in this example I have only one account for Cardano)
Kapture 2025-02-17 at 12 20 27

Copy link
Contributor

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you got multiple accounts?

I do... it does make sense that no account will can be selected if there is more than 1.
Plus that's definitely an improvement πŸ‘

@ejaycoleman ejaycoleman added this pull request to the merge queue Feb 19, 2025
Merged via the queue into develop with commit 6d855fd Feb 19, 2025
46 of 56 checks passed
@ejaycoleman ejaycoleman deleted the feat/LIVE-17004-extract-swap-parameters-from-deeplink branch February 19, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants