-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract swap parameters from deeplink #9214
feat: extract swap parameters from deeplink #9214
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 4 Skipped Deployments
|
|
apps/ledger-live-desktop/src/renderer/hooks/useDeeplinking/useDeepLinkHandler.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me with the amount but the from and to token are wrong:
SwapDeeplink.mov
@thesan Have you got multiple accounts? This currently only works when there is one account per token (in this example I have only one account for Cardano) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you got multiple accounts?
I do... it does make sense that no account will can be selected if there is more than 1.
Plus that's definitely an improvement π
β Checklist
npx changeset
was attached.π Description
Extracts Swap parameters
amountFrom
,fromToken
andtoToken
from ledgerlive://swap deeplinksβ Context
LIVE-17004
π§ Checklist for the PR Reviewers