Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double broadcast on exchange flow [LIVE-15840] #8965

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Jan 21, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests. We still need to manually test swaps
  • Impact of the changes:
    • Swap live-app

📝 Description

Fix double broadcast that could happen on the exchange flow as the useEffect deps could change

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Jan 21, 2025
@Justkant Justkant requested review from a team as code owners January 21, 2025 11:20
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 21, 2025 11:20am
native-ui-storybook ⬜️ Ignored (Inspect) Jan 21, 2025 11:20am
react-ui-storybook ⬜️ Ignored (Inspect) Jan 21, 2025 11:20am
web-tools ⬜️ Ignored (Inspect) Jan 21, 2025 11:20am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 21, 2025
@live-github-bot
Copy link
Contributor

Desktop Bundle Checks

Comparing 19b9e07 against 2b2cd2f.

⚠️ renderer bundle size significantly increased: 38mb -> 38.1mb. Please check if this is expected.

Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Justkant Justkant merged commit db6cc54 into release Jan 21, 2025
41 of 43 checks passed
@Justkant Justkant deleted the bugfix/LIVE-15840 branch January 21, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants