-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Uniswap's term's of use #8842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ 4 Skipped Deployments
|
lpaquet-ledger
previously approved these changes
Jan 8, 2025
sarneijim
reviewed
Jan 8, 2025
apps/ledger-live-desktop/src/renderer/components/TransactionConfirm/ConfirmFooter.tsx
Outdated
Show resolved
Hide resolved
live-github-bot
bot
added
common
Has changes in live-common
translations
Translation files have been touched
labels
Jan 10, 2025
sarneijim
previously approved these changes
Jan 13, 2025
sarneijim
previously approved these changes
Jan 13, 2025
themooneer
reviewed
Jan 13, 2025
apps/ledger-live-desktop/src/renderer/components/TransactionConfirm/ConfirmFooter.tsx
Outdated
Show resolved
Hide resolved
themooneer
reviewed
Jan 13, 2025
apps/ledger-live-desktop/src/renderer/components/TransactionConfirm/ConfirmFooter.tsx
Outdated
Show resolved
Hide resolved
themooneer
reviewed
Jan 13, 2025
apps/ledger-live-desktop/src/renderer/components/TransactionConfirm/ConfirmFooter.tsx
Outdated
Show resolved
Hide resolved
themooneer
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sarneijim
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common
Has changes in live-common
desktop
Has changes in LLD
translations
Translation files have been touched
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
β Context
π§ Checklist for the PR Reviewers