Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Uniswap's term's of use #8842

Merged
merged 7 commits into from
Jan 13, 2025
Merged

feat: Uniswap's term's of use #8842

merged 7 commits into from
Jan 13, 2025

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Jan 8, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner January 8, 2025 11:06
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:27pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:27pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:27pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:27pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 8, 2025
lpaquet-ledger
lpaquet-ledger previously approved these changes Jan 8, 2025
@CremaFR CremaFR requested a review from a team as a code owner January 10, 2025 13:13
@live-github-bot live-github-bot bot added common Has changes in live-common translations Translation files have been touched labels Jan 10, 2025
sarneijim
sarneijim previously approved these changes Jan 13, 2025
sarneijim
sarneijim previously approved these changes Jan 13, 2025
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CremaFR CremaFR requested a review from sarneijim January 13, 2025 14:20
@CremaFR CremaFR merged commit eb948eb into develop Jan 13, 2025
53 of 55 checks passed
@CremaFR CremaFR deleted the feat/uniswapTermsOfUse branch January 13, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants