fix 🐛(llm) ios splashscreen #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
LucasWerey
force-pushed
the
fix/ios_splashscreen_2
branch
from
5a38e5e to
8b96997
Compare
LucasWerey
force-pushed
the
fix/ios_splashscreen_2
branch
from
8b96997 to
e7f9434
Compare
abdurrahman-ledger
approved these changes
Dec 24, 2024
cgrellard-ledger
approved these changes
Dec 24, 2024
abdurrahman-ledger
added a commit
that referenced
this pull request
Jan 8, 2025
This reverts commit 0e6ee7d.
abdurrahman-ledger
added a commit
that referenced
this pull request
Jan 8, 2025
This reverts commit 0e6ee7d.
abdurrahman-ledger
added a commit
that referenced
this pull request
Jan 10, 2025
This reverts commit 0e6ee7d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Fix IOS splashscreen. It wasn't working due to missconfig.
In dev there is a little white/black screen after the launchscreen due to metro loading
We can't use RNSplashScreen since there is known issue with detox. Also it looks quite better to handle this in the native part.
It doesn't look perfect but this will be reworked a day. So for the moment I leave the existing one what it's better than just a white or black screen
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-23.at.12.27.17.mp4
❓ Context
🧐 Checklist for the PR Reviewers