💄 LLM - Landing Pages margin bottom #8674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Comment on lines
+46
to
+52
| ListFooterComponent={ | ||
| hasStickyCta ? ( | ||
| <Flex height={116} /> | ||
| ) : bottomSpacing ? ( | ||
| <Flex height={bottomSpacing} /> | ||
| ) : null | ||
| } |
There was a problem hiding this comment.
we should add a margin anyway if no sticky no?
There was a problem hiding this comment.
That's what it does, if there is no sticky cta and we passed a bottomSpacing parameter, we'll have a spacing in the bottom
There was a problem hiding this comment.
But we can choose to not send a bottomSpacing parameter to not have any spacing in the bottom of the ContentCardsLocation component
mcayuelas-ledger
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Add a margin bottom to the landing pages when there is no sticky cta
❓ Context
🧐 Checklist for the PR Reviewers