fix: LNS Swap for SOL #8640
Merged
fix: LNS Swap for SOL #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Justkant
approved these changes
Dec 9, 2024
Comment on lines
+88
to
+92
| const parentFrom = | ||
| (exchange?.fromAccount?.type === "TokenAccount" && exchange?.fromParentAccount?.currency?.id) || | ||
| ""; | ||
| const parentTo = | ||
| (exchange?.toAccount?.type === "TokenAccount" && exchange?.toParentAccount?.currency?.id) || ""; |
There was a problem hiding this comment.
If we want we could also use exchange?.fromAccount?.currency.parentCurrency.id instead of exchange?.fromParentAccount?.currency?.id but it's fine like that
cgrellard-ledger
approved these changes
Dec 9, 2024
andreicovaciu
deleted the
fix/LIVE-14838-lns-solana-tokens-error-message
branch
DatDraggy
pushed a commit
to DatDraggy/ledger-live
that referenced
this pull request
Jan 6, 2025
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Fix LNS Swap for SOL
❓ Context
🧐 Checklist for the PR Reviewers