fix: display the selected validator #8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
sprohaszka-ledger
requested changes
Dec 9, 2024
| @@ -52,11 +47,20 @@ const ValidatorField = ({ account, delegation, onChangeValidator, selectedPoolId | |||
| setLedgerPoolsLoading(true); | |||
| fetchPoolDetails(account.currency, LEDGER_POOL_IDS) | |||
| .then((apiRes: { pools: Array<StakePool> }) => { | |||
| const filteredPool = apiRes.pools.filter(pool => pool.poolId === delegation?.poolId); | |||
There was a problem hiding this comment.
The best is to implement this logic in getPools.ts file, coin-module Cardano. This way we can add an automated test to check the expected behaviour.
The method in the coin-module car return an Array so the UI call the setCurrentPool without checking the answer.
| <Box flex={1} py={3} alignItems="center" justifyContent="center"> | ||
| <BigSpinner size={35} /> | ||
| </Box> | ||
| ) : ( | ||
| <ScrollLoadingList | ||
| data={ | ||
| showAll | ||
| ? pools.filter(p => !poolIdsToFilterFromAllPools.includes(p.poolId)) | ||
| : ledgerPools | ||
| ? pools.filter(p => p && !poolIdsToFilterFromAllPools.includes(p.poolId)) |
There was a problem hiding this comment.
Optional:
Not sure that imbricated ternary is really readable.
Also, I think pools has always something or nothing, but no optional value (i.e. undefined or null), therefore ? operator is unnecessary.
qperrot
force-pushed
the
bugfix/ada-staking-delegation
branch
from
ca721e3 to
c8e1b38
Compare
sprohaszka-ledger
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Given a user who has an active delegation
When his wants to change the validator
Then clicking on ‘Show less’ does not display the selected validator no the one currently delegating
Screen.Recording.2024-12-06.at.11.19.54.mov
❓ Context
LIVE-14500
🧐 Checklist for the PR Reviewers